Create urls module and remove import package from docs. #1537
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1537 +/- ##
==========================================
+ Coverage 85.87% 85.91% +0.04%
==========================================
Files 35 36 +1
Lines 1883 1889 +6
Branches 313 313
==========================================
+ Hits 1617 1623 +6
Misses 187 187
Partials 79 79
Continue to review full report at Codecov.
|
|
I ran the tests with the previous urls definition where it imports the package, then uses |
|
Thanks, this looks great!
If it's relatively easy to do then yes – this will mean less work when updating old projects; OTOH it's one of the smaller changes and django-upgrade helps with the more annoying changes so maybe it's fine to either fix it when it breaks later or just document it as possibly backwards incompatible. |
|
Nah, it'll be easy. A second urls module then overriding the root URL conf
setting will do the trick.
…On Sat, Dec 4, 2021, 4:25 PM Matthias Kestenholz ***@***.***> wrote:
Thanks, this looks great!
I ran the tests with the previous urls definition where it imports the
package, then uses include(debug_toolbar.urls) and confirmed that this
will be compatible. @matthiask <https://github.com/matthiask> do you
think we should formalize this in the tests?
If it's relatively easy to do then yes – this will mean less work when
updating old projects; OTOH it's one of the smaller changes and
django-upgrade helps with the more annoying changes so maybe it's fine to
either fix it when it breaks later or just document it as possibly
backwards incompatible.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1537 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJYZP63VTCS7ETA6GFADGDUPKBMPANCNFSM5JL3PKRA>
.
|
By creating a urls module, devs can include the urls with a string
path to the urls, include('debug_toolbar.urls').
This allows the cache panel to enable the instrumentation when the app is ready.
Update the __init__.py module to use the proper urls string path and app name. This will maintain backwards compatability with the documentations previous installation instructions.
By creating a urls module, devs can include the urls with a string
path to the urls, include('debug_toolbar.urls').
Closes #1506