Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary mock dependency #1572

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

adamchainz
Copy link
Contributor

Presumably left over from Python 2, since Python 3 added mock to the standard library.

Presumably left over from Python 2, since Python 3 added mock to the standard library.
Copy link
Member

@matthiask matthiask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git log -Smock doesn't find any uses of mock (excluding unittest.mock) at all so I suspect that maybe this has never been used at all?

@adamchainz
Copy link
Contributor Author

🤷

@matthiask matthiask merged commit 9551a7c into django-commons:main Jan 12, 2022
@matthiask
Copy link
Member

Thanks!

@adamchainz adamchainz deleted the remove_mock_dep branch January 12, 2022 12:45
@tim-schilling
Copy link
Member

Nope, I added it for some reason and I can't tell what it was for. Likely a mistake.

gone pushed a commit to gone/django-debug-toolbar that referenced this pull request Jan 16, 2022
Presumably left over from Python 2, since Python 3 added mock to the standard library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants