'djdt' is not a registered namespace #1405

[VeldaKiara]

Description

The error was 'djdt' is not a registered namespace. It occurred due to misconfiguration of the toolbar settings as well as the debug settings.

Fixes # (issue 1405)

• Added a check to result in an official error
• Added tests for the check
• Updated the docs with the right way to configure the toolbar to work with debug without an issue

Checklist:

• I have added the relevant tests for this change.
• I have added an item to the Pending section of docs/changes.rst.

[elineda]

The test with make test doesn't work, you need to change the setting on test to change accept test of the debug toolbar

DEBUG_TOOLBAR_CONFIG = {
    # Django's test client sets wsgi.multiprocess to True inappropriately
    "RENDER_PANELS": False,
    "RUNNING_TESTS": False
}

[VeldaKiara]

@elineda @matthiask @tim-schilling could you test it out and let me know if everything is good and any changes or suggestions you have at this point?

[VeldaKiara]

@elineda @matthiask @tim-schilling could you test it out and let me know if everything is good and any changes or suggestions you have at this point?

Is it okay to merge?

[tim-schilling]

@VeldaKiara no, we have some miscommunications yet. I started on a change that will better communicate them. I'll try to push that up tonight.

[VeldaKiara]

@VeldaKiara no, we have some miscommunications yet. I started on a change that will better communicate them. I'll try to push that up tonight.

Awesome, I will be waiting on the changes.

[tim-schilling]

@VeldaKiara I pushed some changes to the check and the settings in the example app. Let me know what you think.

I suspect we should ignore our new check in the test settings until we test it explicitly. In that case we should use the @override_settings decorator to enable it. That should get the tests to pass.

Regarding the documentation, maybe we keep the docs as they are, then link them to the example app to see how it's setup in an advanced configuration?

[VeldaKiara]

Let me check out the changes.

I think that would work to pointing to the example app

[VeldaKiara]

I have incorporated the changes requested.
Let me know if you have any more suggestions.

[tim-schilling]

This is coming along nicely Velda. I've got a few suggested changes. Hopefully it doesn't break any of the tests.

[VeldaKiara]

I have removed the patch decorator, updated the docs and made some changes to the test_panel_empty check for the test to pass

[tim-schilling]

Thank you for sticking with this one @VeldaKiara!

@matthiask @elineda @living180 could one of you give this a look over to confirm it makes sense to you? Specifically the naming and documentation.

[matthiask]

Thanks for working on this!

I mostly have suggestions and questions for clarifications, so I'm approving already.

[matthiask]

I'm not sure why you're modifying the dt_settings.get_config() return value instead of using e.g. with override_settings(...)? I suspect that there's a good reason for it; if there is, please add a short docstring.

[tim-schilling]

If we were to use override_settings, we'd have to define the entire DEBUG_TOOLBAR_CONFIG dictionary. And I don't think there's a merge settings method.

[tim-schilling]

Let me know what you think of the new comment.

[matthiask]

Thanks! No further comments :-)

[matthiask]

I think this is ready to merge, or is there anything left to do?

[VeldaKiara]

👯🏾👯🏾👯🏾👯🏾