fix ch zip #154
Merged
fix ch zip #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| The range 9480 to 9499 is assigned to zip codes from Liechtenstein. | ||
|
|
||
| See: | ||
| http://en.wikipedia.org/wiki/Postal_codes_in_Switzerland_and_Liechtenstein |
There was a problem hiding this comment.
I'm not sure this detailed explanation is useful here. I would simply add the range and the wikipedia link.
|
Thanks, looks good now. Could you please merge your commits? |
|
there you go, thanks for the quick feedback |
|
Test failures are unrelated to this patch. Thanks for your work. |
claudep
added a commit
that referenced
this pull request
Jun 3, 2015
Fixed validation of Swiss localflavor zip code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to http://en.wikipedia.org/wiki/List_of_postal_codes_of_Switzerland and
http://en.wikipedia.org/wiki/Postal_codes_in_Switzerland_and_Liechtenstein the Swiss
zip code has a range from 1000-9000 similar to the belgian ones. The current
implementation wrongly accepts 0000 as a valid zip code.