-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created ES models.py #357
Created ES models.py #357
Conversation
Added models for ES-ID document and ES-PostalCodes
Models for National-ID and PostalCodes
Add DNI and Postalcode model Isorted
Failed with:
I haven't edit this files: why? |
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=========================================
- Coverage 95.93% 95.8% -0.13%
=========================================
Files 157 158 +1
Lines 3981 4003 +22
Branches 523 523
=========================================
+ Hits 3819 3835 +16
- Misses 98 104 +6
Partials 64 64
Continue to review full report at Codecov.
|
A dependency in prospector was updated which found the issue with the Norway localflavor. This is now fixed in master. Can you rebase this branch with master? I'll do a review once it's rebased. Thanks. |
Added models for ES-ID document and ES-PostalCodes
Models for National-ID and PostalCodes
Add DNI and Postalcode model Isorted
orthographic error
Have I been done the rebase correctly? Sorry I have no more knowledges |
Added models for ES-ID document and ES-PostalCodes.
I'm newbie with Django.
Please correct me if something is wrong.
I inspired this models from us/models.py
Thanks for your contribution!
A checklist is included below which helps us keep the code contributions
consistent and helps speed up the review process. You can add additional
commits to your pull request if you haven't met all of these points on your
first version.
All Changes
Add an entry to the docs/changelog.rst describing the change.
Add an entry for your name in the docs/authors.rst file if it's not
already there.
Adjust your imports to a standard form by running this command:
New Fields Only
Prefix the country code to all fields.
Field names should be easily understood by developers from the target
localflavor country. This means that English translations are usually
not the best name unless it's for something standard like postal code,
tax / VAT ID etc.
Prefer 'PostalCodeField' for postal codes as it's
international English; ZipCode is a term specific to the United
States postal system.
Add meaningful tests. 100% test coverage is not required but all
validation edge cases should be covered.
Add
.. versionadded:: <next-version>
comment markers to newlocalflavors.
Add documentation for all fields.