Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make vault withdraw page mobile resp. #308

Merged
merged 4 commits into from
Nov 30, 2024
Merged

feat: make vault withdraw page mobile resp. #308

merged 4 commits into from
Nov 30, 2024

Conversation

Oshioke-Salaki
Copy link
Contributor

fixes #295

Made withdraw vault page responsive on mobile screens.

@whateverfw whateverfw self-requested a review November 29, 2024 21:41
@djeck1432 djeck1432 self-requested a review November 29, 2024 21:44
whateverfw
whateverfw requested changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that content is inside a card with border just like in Figma, currently desktop version doesn't correspond to Figma
image
Figma:
image

Not sure if that's particularly because of mobile changes, but please fix this as well, thanks!

whateverfw
whateverfw approved these changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

djeck1432
djeck1432 approved these changes Nov 30, 2024
View reviewed changes
Copy link
Owner

@djeck1432 djeck1432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks good to me

@djeck1432 djeck1432 merged commit ab6a2d2 into djeck1432:main Nov 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeck1432 djeck1432 djeck1432 approved these changes

@whateverfw whateverfw whateverfw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Frontend] Vault withdraw page [mobile]
3 participants
@Oshioke-Salaki @djeck1432 @whateverfw