Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default compiler should not depend on DUB's own build environment #678

Merged
merged 1 commit into from
Sep 13, 2015

Conversation

schuetzm
Copy link
Contributor

When building DUB with DMD=ldmd2 ./build.sh, the resulting dub binary uses ldmd2 as default compiler at runtime. But IMO the behaviour of dub at runtime should not depend on the environment it was built in.

@s-ludwig
Copy link
Member

Since we now have the generic findCompiler functionality, I'd agree that this isn't necessary anymore and indeed not particularly desirable from a distribution POV. However, I'd not want to remove this without supporting a "defaultCompiler" field in m_userConfig/m_systemConfig as a run-time replacement (I think there have been requests for that anyway).

@s-ludwig
Copy link
Member

BTW, I'll have a look at the user config now.

s-ludwig added a commit that referenced this pull request Sep 13, 2015
A "defaultCompiler" field in the user or system wide DUB configuration file can be used for that now.
s-ludwig added a commit that referenced this pull request Sep 13, 2015
The default compiler should not depend on DUB's own build environment
@s-ludwig s-ludwig merged commit 56fb24b into dlang:master Sep 13, 2015
@schuetzm schuetzm deleted the build-time-independent-compiler branch September 13, 2015 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants