Merge pull request #127 from cdelafuente-r7/fix_stringz_max_length_trim

Fix Stringz :max_length trimming
dmendel · Jul 21, 2020 · f601601 · f601601
2 parents c6fae73 + 27be2bf
commit f601601
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/bindata/stringz.rb b/lib/bindata/stringz.rb
@@ -80,7 +80,7 @@ def truncate_after_first_zero_byte!(str)
     def trim_to!(str, max_length = nil)
       if max_length
         max_length = 1 if max_length < 1
-        str.slice!(max_length)
+        str.slice!(max_length..-1)
         if str.length == max_length && str[-1, 1] != "\0"
           str[-1, 1] = "\0"
         end

diff --git a/test/stringz_test.rb b/test/stringz_test.rb
@@ -106,12 +106,12 @@
   end
 
   it "trims values greater than max_length" do
-    obj.assign("abcde")
+    obj.assign("abcdefg")
     obj.must_equal "abcd"
   end
 
   it "writes values greater than max_length" do
-    obj.assign("abcde")
+    obj.assign("abcdefg")
     obj.to_binary_s.must_equal_binary "abcd\0"
   end