Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates on foundry config #4

Merged
merged 3 commits into from
Dec 29, 2022
Merged

Minor updates on foundry config #4

merged 3 commits into from
Dec 29, 2022

Conversation

kootsZhin
Copy link
Contributor

@kootsZhin kootsZhin commented Dec 29, 2022 •
edited
Loading

  • change default to profile.default in foundry.toml
  • change to use forge install in README
  • add remappings

@kootsZhin kootsZhin changed the title chore: update foundry.toml Minor updates on foundry config Dec 29, 2022
@dmfxyz
Copy link
Owner

dmfxyz commented Dec 29, 2022

Thanks -- looks good. Let me just fix the slither workflow so that it runs before we merge this.

@dmfxyz
Copy link
Owner

dmfxyz commented Dec 29, 2022 •
edited
Loading

@kootsZhin merge upstream main when you get a chance

@kootsZhin
Copy link
Contributor Author

@kootsZhin merge upstream main when you get a chance

done!

dmfxyz
dmfxyz approved these changes Dec 29, 2022
View reviewed changes
Copy link
Owner

@dmfxyz dmfxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@dmfxyz dmfxyz merged commit 1d9566b into dmfxyz:main Dec 29, 2022
@kootsZhin kootsZhin deleted the minor-fix branch December 29, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmfxyz dmfxyz dmfxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kootsZhin @dmfxyz