Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial-release nvcc v10.1 issue with thread_local.h #579

Merged
merged 1 commit into from
Nov 5, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion include/dmlc/thread_local.h
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ class ThreadLocalStore {
static MX_THREAD_LOCAL T* ptr = nullptr;
if (ptr == nullptr) {
ptr = new T();
Singleton()->RegisterDelete(ptr);
// Syntactic work-around for the nvcc of the initial cuda v10.1 release,
// which fails to compile 'Singleton()->' below. Fixed in v10.1 update 1.
(*Singleton()).RegisterDelete(ptr);
}
return ptr;
#endif
Expand Down