[IO] Return bytes written in Stream::Write #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `Stream::Write` method to return the number of bytes written, analogous to the current behavior of `Stream::Read`. This information is necessary to correctly model partial writes to a buffered stream. (e.g. Writing to a OS pipe when the pipe's buffer is smaller than the data to be written.)
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 14, 2024
This commit updates TVM implementations of `dmlc::Stream`. With dmlc/dmlc-core#686, this API now requires the `Write` method to return the number of bytes written. This change allows partial writes to be correctly handled.
This was referenced May 14, 2024
hcho3
approved these changes
May 22, 2024
tqchen
pushed a commit
to apache/tvm
that referenced
this pull request
May 30, 2024
* [Runtime] Compatibility with dmlc::Stream API changes This commit updates TVM implementations of `dmlc::Stream`. With dmlc/dmlc-core#686, this API now requires the `Write` method to return the number of bytes written. This change allows partial writes to be correctly handled. * Update dmlc-core version * lint fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
Stream::Writemethod to return the number of bytes written, analogous to the current behavior ofStream::Read. This information is necessary to correctly model partial writes to a buffered stream. (e.g. Writing to a OS pipe when the pipe's buffer is smaller than the data to be written.)