Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix monodepth2 tutorials #1459

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Fix monodepth2 tutorials #1459

merged 2 commits into from
Sep 25, 2020

Conversation

KuangHaofei
Copy link
Contributor

Comments the step of loading kitti dataset.

@mli
Copy link
Member

mli commented Sep 25, 2020

Job PR-1459-2 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1459/2/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

bryanyzhu
bryanyzhu approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@bryanyzhu bryanyzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryanyzhu
Copy link
Collaborator

@zhreshold This PR comment out get_data part in training monodepth2 model, which makes it easier to pass doc test. The PR is already complete, feel free to merge it. Thank you.

@zhreshold zhreshold merged commit c109792 into dmlc:master Sep 25, 2020
@KuangHaofei KuangHaofei deleted the fix_monodepth2_tutorials branch October 12, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhreshold zhreshold zhreshold approved these changes

@bryanyzhu bryanyzhu bryanyzhu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KuangHaofei @mli @bryanyzhu @zhreshold