This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
[BUGFIX]Fix chdir Error when invoked from Makefile #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 81 81
Lines 7345 7345
=======================================
Hits 6421 6421
Misses 924 924 |
|
Job PR-1193/1 is complete. |
6 tasks
chenw23
pushed a commit
to chenw23/gluon-nlp
that referenced
this pull request
Apr 15, 2020
Now adopts the great new enhancements from dmlc#1191 , dmlc#1192 , dmlc#1193 , dmlc#1194 , dmlc#1195 , dmlc#1196 , dmlc#1197 , dmlc#1198 and dmlc#1120 . The pull requests above fixed various errors in the previous make docs command and added new switch options. Now the commands mentioned in this documentation are strictly error-free.
chenw23
pushed a commit
to chenw23/gluon-nlp
that referenced
this pull request
Apr 15, 2020
Now adopts the great new enhancements from dmlc#1191 , dmlc#1192 , dmlc#1193 , dmlc#1195 , dmlc#1196 , dmlc#1197 , dmlc#1198 and dmlc#1200 . The pull requests above fixed various errors in the previous make docs command and added new switch options. Now the commands mentioned in this documentation are strictly error-free.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a bug fix, rather than an enhancement.
Currently this file is invoked smoothly from CI, because CI passes the full path as the argument to this python script. However, when invoked from Makefile, using the command
make docs, only file name is passed to this file, resulting in theinput_dirvariable to be empty string, so that theos.chdir()will fail.More detailed explanation:
When we use
make docs, the L60 ofMakefilewill be executed, and then L86 ofMakefilewill be executed. See in L89, variableBASENAMEwill be the file name and variableDIRwill be the directory. In L96, onlyBASENAMEis passed toMD2IPYNBas an argument. So there will be error in the python file.With this fix, the python script doesn't need to change directory explicitly because in L92 of the
Makefile, the directory is changed already. So this fix will work fine.This pull request is compatible with the existing CI, and can make Makefile work fine again.
Checklist
Essentials
Changes
Comments
cc @dmlc/gluon-nlp-team