Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[BUGFIX] TextCNN rand model downloads pretrained vectors even if not needed #1222

Merged
merged 1 commit into from
May 7, 2020
Merged

[BUGFIX] TextCNN rand model downloads pretrained vectors even if not needed #1222

merged 1 commit into from
May 7, 2020
+19 −13

Conversation

avinashsai
Copy link
Member

Fixes #1217

@avinashsai avinashsai requested a review from a team as a code owner May 5, 2020 22:06
@szha szha requested a review from leezu May 5, 2020 22:08
@mli
Copy link
Member

mli commented May 5, 2020

Job PR-1222/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1222/1/index.html

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #1222 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1222   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files          81       81           
  Lines        7347     7347           
=======================================
  Hits         6423     6423           
  Misses        924      924

@avinashsai
Copy link
Member Author

@leezu All checks have passed. Please review this

@leezu leezu merged commit f429d52 into dmlc:master May 7, 2020
@leezu
Copy link
Contributor

leezu commented May 7, 2020

Thanks @avinashsai

@avinashsai avinashsai deleted the master branch May 7, 2020 19:00
@avinashsai avinashsai mentioned this pull request May 7, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avinashsai @mli @leezu