Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[CI][DOC] Improve website build process + Fix doc #1418

Merged
merged 21 commits into from
Oct 30, 2020

Conversation

barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Oct 30, 2020

Description

  1. Notebook fails compilation will be shown in CI and developers can download build artifacts to find the error message.
  2. After [MODEL] update hybrid_forward to use deferred compute #1356 is merged, tutorials question_answering and text_prediction_part2 will fail the notebook compilation because these notebooks need to be updated. Now both of them are updated.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@barry-jin barry-jin requested a review from a team as a code owner October 30, 2020 00:49
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #1418 into master will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1418      +/-   ##
==========================================
- Coverage   85.24%   85.05%   -0.19%     
==========================================
  Files          53       53              
  Lines        6954     6987      +33     
==========================================
+ Hits         5928     5943      +15     
- Misses       1026     1044      +18     
Impacted Files Coverage Δ
src/gluonnlp/attention_cell.py 80.39% <0.00%> (ø)
src/gluonnlp/data/loading.py 78.11% <0.00%> (-5.29%) ⬇️
src/gluonnlp/utils/lazy_imports.py 66.08% <0.00%> (+6.33%) ⬆️
src/gluonnlp/base.py 96.66% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0484e64...a7cfa4e. Read the comment docs.

@github-actions
Copy link

@barry-jin barry-jin changed the title [WIP][CI][DOC] Improve website build process + Try to fix doc [CI][DOC] Improve website build process + Fix doc Oct 30, 2020
@barry-jin barry-jin mentioned this pull request Oct 30, 2020
6 tasks
@github-actions
Copy link

1 similar comment
@github-actions
Copy link

@github-actions
Copy link

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxjscience sxjscience merged commit b6906f8 into dmlc:master Oct 30, 2020
@barry-jin barry-jin deleted the improve-ci2 branch October 30, 2020 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants