Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[Docker] Update Docker #1454

Merged
merged 5 commits into from
Dec 8, 2020
Merged

[Docker] Update Docker #1454

merged 5 commits into from
Dec 8, 2020

Conversation

barry-jin
Copy link
Contributor

Description

Update docker

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@barry-jin barry-jin requested a review from a team as a code owner December 7, 2020 18:39
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #1454 (bc9b5ca) into master (c6db365) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1454   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files          53       53           
  Lines        6987     6987           
=======================================
  Hits         5975     5975           
  Misses       1012     1012           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6db365...bc9b5ca. Read the comment docs.

@barry-jin barry-jin changed the title [Docker] Update Docker [WIP][Docker] Update Docker Dec 7, 2020
@barry-jin barry-jin changed the title [WIP][Docker] Update Docker [Docker] Update Docker Dec 7, 2020
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 7, 2020

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxjscience
Copy link
Member

I think the test will pass after merge master.

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

@sxjscience sxjscience merged commit d4a1d5d into dmlc:master Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants