Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[TVM] Fix Tvm Integration #1502

Merged
merged 5 commits into from
Jan 23, 2021
Merged

Conversation

barry-jin
Copy link
Contributor

Description

Fix issue #1425. Update docker and enable tvm test.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Add monkey patch to update operator map in TVM's MXNet frontend locally.

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@barry-jin barry-jin requested a review from a team as a code owner January 23, 2021 03:54
@sxjscience
Copy link
Member

FYI @icemelon9 @yzhliu , we added the monkey patch to try to fix the TVM conversion from the GluonNLP side.

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #1502 (7fe0c30) into master (09f3435) will decrease coverage by 0.16%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   86.54%   86.37%   -0.17%     
==========================================
  Files          53       54       +1     
  Lines        7326     7349      +23     
==========================================
+ Hits         6340     6348       +8     
- Misses        986     1001      +15     
Impacted Files Coverage Δ
src/gluonnlp/utils/tvm_utils.py 92.30% <92.30%> (ø)
src/gluonnlp/utils/misc.py 54.64% <100.00%> (+0.22%) ⬆️
src/gluonnlp/data/loading.py 78.11% <0.00%> (-5.29%) ⬇️
src/gluonnlp/data/tokenizers/huggingface.py 71.54% <0.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f3435...7fe0c30. Read the comment docs.

@sxjscience sxjscience merged commit 4624e6b into dmlc:master Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants