Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

PyTorch attention cells, transformer, bert and conversion script #1532

Merged
merged 7 commits into from
Feb 26, 2021

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Feb 25, 2021

Add PyTorch attention cells, transformer, bert and conversion script. Correctness verified via included tests and conversion script.

@leezu leezu requested a review from sxjscience February 25, 2021 23:50
@leezu leezu requested a review from a team as a code owner February 25, 2021 23:50
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #1532 (dbf8ce7) into master (223f1f6) will decrease coverage by 0.58%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1532      +/-   ##
==========================================
- Coverage   86.37%   85.79%   -0.59%     
==========================================
  Files          55       55              
  Lines        7522     7426      -96     
==========================================
- Hits         6497     6371     -126     
- Misses       1025     1055      +30     
Impacted Files Coverage Δ
src/gluonnlp/utils/misc.py 54.09% <29.41%> (-2.26%) ⬇️
src/gluonnlp/__init__.py 100.00% <100.00%> (ø)
src/gluonnlp/base.py 100.00% <100.00%> (ø)
conftest.py 76.31% <0.00%> (-9.94%) ⬇️
src/gluonnlp/data/loading.py 76.55% <0.00%> (-2.28%) ⬇️
src/gluonnlp/utils/lazy_imports.py 58.42% <0.00%> (-2.25%) ⬇️
src/gluonnlp/data/tokenizers/yttm.py 81.73% <0.00%> (-1.02%) ⬇️
src/gluonnlp/data/tokenizers/spacy.py 65.33% <0.00%> (-0.91%) ⬇️
src/gluonnlp/data/tokenizers/huggingface.py 71.06% <0.00%> (-0.78%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 223f1f6...dbf8ce7. Read the comment docs.

@github-actions
Copy link

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve. We can improve the testing later since this is the initial version of the pytorch-based GluonNLP.

@sxjscience sxjscience merged commit 8e41885 into dmlc:master Feb 26, 2021
@leezu leezu deleted the torch branch February 26, 2021 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants