Skip to content

Commit

Permalink
rdma_van: lint
Browse files Browse the repository at this point in the history
  • Loading branch information
changlan committed Jul 16, 2019
1 parent d7481c1 commit bdb1a24
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 2 deletions.
4 changes: 3 additions & 1 deletion include/ps/internal/postoffice.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
#include <mutex>
#include <algorithm>
#include <vector>
#include <unordered_map>
#include <memory>
#include "ps/range.h"
#include "ps/internal/env.h"
#include "ps/internal/customer.h"
Expand Down Expand Up @@ -35,7 +37,7 @@ class Postoffice {
/**
* \brief terminate the system
*
* All nodes should call this function before existing.
* All nodes should call this function before existing.
* \param do_barrier whether to do block until every node is finalized, default true.
*/
void Finalize(const int customer_id, const bool do_barrier = true);
Expand Down
1 change: 1 addition & 0 deletions include/ps/internal/threadsafe_queue.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <mutex>
#include <condition_variable>
#include <memory>
#include <utility>
#include "ps/base.h"
namespace ps {

Expand Down
1 change: 1 addition & 0 deletions include/ps/kv_app.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#include <algorithm>
#include <utility>
#include <vector>
#include <unordered_map>
#include "ps/base.h"
#include "ps/simple_app.h"
namespace ps {
Expand Down
5 changes: 4 additions & 1 deletion src/rdma_van.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,14 @@
#include <algorithm>
#include <map>
#include <queue>
#include <memory>
#include <set>
#include <string>
#include <thread>
#include <tuple>
#include <unordered_map>
#include <unordered_set>
#include <utility>
#include <vector>

#include "ps/internal/threadsafe_queue.h"
Expand Down Expand Up @@ -528,7 +531,7 @@ class RDMAVan : public Van {
CHECK(!ibv_destroy_comp_channel(comp_event_channel_))
<< "Failed to destroy channel";

// TODO: ibv_dealloc_pd sometimes complains about busy resources
// TODO(changlan): ibv_dealloc_pd sometimes complains about busy resources

PS_VLOG(1) << "Destroying listener.";
rdma_destroy_id(listener_);
Expand Down
1 change: 1 addition & 0 deletions src/zmq_van.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <zmq.h>
#include <string>
#include <thread>
#include <unordered_map>
#include "ps/internal/van.h"
#if _MSC_VER
#define rand_r(x) rand()
Expand Down

0 comments on commit bdb1a24

Please sign in to comment.