Priority-based Push and Pull #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an additional feature ps-lite has to support in order to implement priority-based parameter propagation in MXNet (JIRA ticket - https://issues.apache.org/jira/browse/MXNET-1294). |
anandj91
force-pushed
the
prio
branch
3 times, most recently
from
c677efd to
fbd2c51
Compare
|
Could you resolve the conflict? |
|
@anandj91 I noticed that you modified the Van base class, especially the new Push() interface. I want to understand whether this is backward compatible, e.g., with the recently merged RDMA Van? #151 IMHO, a cleaner implementation is to keep the Van base class unmodified (as much as possible), just inherit from it (or from ZMQVan) and create your own Van, e.g., P3Van. Users are free to use it or fall back to other options, by setting environmental variables. |
Messages sent based on a assigned priority Higher priority messages gets preference over lower priority ones Add environment variable for setting high water mark for zmq
|
@anandj91 The latest P3Van looks good! Thank you. |
eric-haibin-lin
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages sent based on an assigned priority
Higher priority messages gets preference over lower priority ones