Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable flake8 for Python #1142

Merged
merged 1 commit into from
Apr 27, 2016
Merged

Enable flake8 for Python #1142

merged 1 commit into from
Apr 27, 2016

Conversation

sinhrks
Copy link
Contributor

@sinhrks sinhrks commented Apr 24, 2016

Enable flake8 in addition to lint, which performs static analysis of Python code.

I could find missing import of pickle and XGBoostError, and fixed in this PR.

@tqchen
Copy link
Member

tqchen commented Apr 27, 2016

LGTM, thanks for the contribution

@tqchen tqchen merged commit 43c073d into dmlc:master Apr 27, 2016
@sinhrks sinhrks deleted the flake8 branch April 27, 2016 02:53
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants