-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More functionality for model attributes #1198
Conversation
ctypes.byref(length), | ||
ctypes.byref(sarr))) | ||
res = from_cstr_to_pystr(sarr, length) | ||
return res |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how can it become list of strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem, I mistunderstand the function from_cstr_to_pystr
Thanks for the changes. It LGTM. We might want to make python API consistent with R's, i.e. remove get_attr_names, but directly provides a attributes function that returns a dict of name->value |
Done. Note that Python's |
This sounds good to me, thanks! |
Let me know if "setting null value means delete" is not acceptable for C or Python interface. I can add separate attr deletion methods.