-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] various R code maintenance #1964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e its intent clear
@hetong007 can you help review this? |
Current coverage is 30.73% (diff: 100%)@@ master #1964 diff @@
==========================================
Files 72 72
Lines 5821 5821
Methods 885 885
Messages 0 0
Branches 580 580
==========================================
+ Hits 1787 1789 +2
+ Misses 3956 3955 -1
+ Partials 78 77 -1
|
hetong007
approved these changes
Jan 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to clear a number of long-standing and recently found annoyances and problems.
xgb.Booster
model when it has an invalid handle, e.g., when it was loaded as a regular R object. Also provide users with a functionxgb.Booster.complete
to restore a missing handle. Relevant: save the model under caret #1955, booster handle is invalid #1958xgb.Booster
should only depend on the presence ofwatchlist
, but not onverbose
value. I've got a number of complaints about this previous side-effect ofverbose
.xgb.Booster
is useful for bookkeeping and for making further analysis of the model easier.I didn't add anything relevant to the new fast histogram updater yet.