[Breaking] Update sklearn interface. #4929

trivialfis · 2019-10-10T08:43:19Z

Remove nthread, seed, silent. Add tree_method, gpu_id, num_parallel_tree. Fix num_boost_round and early_stopping_rounds in xgboost.train() API #4909.
Check data shape. Fix IndexError: tuple index out of range #4896.
Check element of eval_set is tuple. Fix Sklearn-API: better description for syntax errors #4875
Add doc for random_state with hogwild. Fixes gblinear non-determinism #4919

RAMitchell

LGTM, except there is a failing test related to one of the new checks with dask.

trivialfis · 2019-10-12T06:31:58Z

@RAMitchell Not sure about it. Seems gone.

trivialfis · 2019-10-12T06:49:15Z

Merging as all single GPU tests have passed, and non of the changes is related to mgpu (dask).

trivialfis added 3 commits October 10, 2019 04:30

Remove nthread', seed', silent'. Add tree_method', `gpu_id'.

8b7d5d3

Check data shape.

8e4c193

Fix dmlc#4896.

Check eval_set is tuple.

289f8b3

Fix dmlc#4875

trivialfis changed the title ~~Update sklearn interface.~~ [Breaking] Update sklearn interface. Oct 10, 2019

trivialfis requested a review from RAMitchell October 10, 2019 08:43

trivialfis added 5 commits October 10, 2019 04:48

Add num_parallel tree.

a2b6838

Add tests.

2c6ad0e

Fix n_jobs.

dfe1b68

Missed a test.

cc47be6

Add doc for random_state with hogwild

0bd180f

Fixes dmlc#4919 .

RAMitchell reviewed Oct 12, 2019

View reviewed changes

trivialfis merged commit 4bbf062 into dmlc:master Oct 12, 2019

trivialfis deleted the sklearn branch October 13, 2019 12:02

trivialfis mentioned this pull request Dec 24, 2019

Tracking deprecated features. #3986

Open

lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020

Provide feedback