Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate positional arguments. #6365

Merged
merged 14 commits into from
Nov 13, 2020
Merged

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Nov 10, 2020

Deprecate positional arguments in following functions:

  • __init__ for all classes in sklearn module.
  • fit method for all classes in sklearn module.
  • set_info for DMatrix class.

Refactor the evaluation matrices handling.

Close #6172 .

@codecov-io
Copy link

codecov-io commented Nov 10, 2020

Codecov Report

Merging #6365 (49bdb89) into master (519cee1) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6365      +/-   ##
==========================================
+ Coverage   81.31%   81.49%   +0.17%     
==========================================
  Files          12       12              
  Lines        3425     3458      +33     
==========================================
+ Hits         2785     2818      +33     
  Misses        640      640              
Impacted Files Coverage Δ
python-package/xgboost/core.py 80.70% <100.00%> (+0.65%) ⬆️
python-package/xgboost/sklearn.py 89.49% <100.00%> (+0.45%) ⬆️
python-package/xgboost/tracker.py 93.97% <0.00%> (-1.21%) ⬇️
python-package/xgboost/libpath.py 55.55% <0.00%> (ø)
python-package/xgboost/training.py 96.52% <0.00%> (+0.03%) ⬆️
python-package/xgboost/callback.py 93.15% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519cee1...49bdb89. Read the comment docs.

@hcho3 hcho3 added the Blocking label Nov 12, 2020
python-package/xgboost/sklearn.py Outdated Show resolved Hide resolved
python-package/xgboost/sklearn.py Show resolved Hide resolved
python-package/xgboost/sklearn.py Show resolved Hide resolved
python-package/xgboost/sklearn.py Show resolved Hide resolved
@trivialfis trivialfis merged commit fcfeb49 into dmlc:master Nov 13, 2020
@trivialfis trivialfis deleted the deprecated-pos-args branch November 13, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Deprecate position arguments and encourage users to use keyword arguments only
3 participants