Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

probable typo #8386

Merged
merged 3 commits into from
Oct 25, 2022
Merged

probable typo #8386

merged 3 commits into from
Oct 25, 2022

Conversation

thomasastanley
Copy link
Contributor

This is probably a typo, although I'm not 100% it's not referring to https://shap.readthedocs.io/en/latest/index.html

This is probably a typo, although I'm not 100% it's not referring to https://shap.readthedocs.io/en/latest/index.html
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a typo. Would you like to help change it into upper case?

according to trivialfis, this is not a typo
@thomasastanley
Copy link
Contributor Author

Ok, i capitalized it. i leave it up to you whether to merge or close. thanks for letting me know.

@trivialfis
Copy link
Member

Thank you for the change, but could you please help change the whole term into upper case?

SHAP (SHapley Additive exPlanations)

@trivialfis trivialfis merged commit ba9cc43 into dmlc:master Oct 25, 2022
@thomasastanley thomasastanley deleted the patch-1 branch October 26, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants