Hash-Pinning Dependencies #8460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joyce Brum <[email protected]>
trivialfis
approved these changes
Nov 17, 2022
|
Yes it is ready, I was waiting for some actions to run before changing it to ready. I decided to break it into more PRs, because I'm still trying to understand the best approach to deal with the Dockerfiles and the python dependencies mentioned in the actions/dockerfiles, I'm concerned that they would be relevant to tests and pinning it would affect the tests. So at first we should only pin these safe ones and later when I got more details on what can or cannot be pinned I can open another issue to continue. Thank you for the concerns in the issue discussion, all of them were pretty relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8438