-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jvm-packages] change DeviceQuantileDmatrix into QuantileDMatrix #8461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mark the change as breaking.
The new QuantileDMatrix
accepts both CPU and GPU based inputs, can we implement it on JVM side as well?
So you mean we also change the CPU way to build QuantileDMatrix instead of plain DMatrix? |
Yes, similar to pyspark interface, we can have |
Ok, I will file another PR for it. |
@trivialfis please help to check the CI why the xgboost-gpu tests run on windows and mac? |
There's an undefined symbol: |
Thx, fixed it. But I'm still curious why the test can pass in ubuntu? and I locally build CPU version with USE_CUDA=OFF, and it still pass |
Thank you for the quick fix! triggered the CI. |
@hcho3 Could you please help check whether the CI is working alright? |
@trivialfis An EC2 worker running Windows got stuck and hung for 10 hours. I had to manually kill it. |
@trivialfis please help to trigger the CI. Thx |
Done. |
@trivialfis Seems the CI is not triggered. |
I triggered it again. |
Does the python test have some issues?
|
} | ||
|
||
@Override | ||
public void setLabel(Column column) throws XGBoostError { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remind me what's the reason behind setters not being supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is renamed by DeviceQuantileDMatrix which is not supporting setter before (when the PR was merged). Will file another PR to support setter if it indeed has supported that.
@trivialfis @hcho3 please help to trigger the CI. Thx |
Done |
@hcho3 @trivialfis please help to trigger the CI again, I just merged the latest commits into this PR. Thx |
@trivialfis please help to check why python test failed in this CI, I suppose this PR won't touch any python code. |
@wbo4958 I re-created the machine env and re-triggered the tests. The CI is passing on the |
Thx @hcho3, @trivialfis please help to review again. Thx |
To fix #8453