Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jvm-packages] change DeviceQuantileDmatrix into QuantileDMatrix #8461

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Nov 11, 2022

To fix #8453

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark the change as breaking.

The new QuantileDMatrix accepts both CPU and GPU based inputs, can we implement it on JVM side as well?

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 17, 2022

So you mean we also change the CPU way to build QuantileDMatrix instead of plain DMatrix?

@trivialfis
Copy link
Member

Yes, similar to pyspark interface, we can have QuantileDMatrix as default for both hist and gpu_hist.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 18, 2022

Ok, I will file another PR for it.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 21, 2022

@trivialfis please help to check the CI why the xgboost-gpu tests run on windows and mac?

@trivialfis
Copy link
Member

There's an undefined symbol: XGQuantileDMatrixCreateFromCallbackImpl when compiling without CUDA.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 22, 2022

Thx, fixed it.

But I'm still curious why the test can pass in ubuntu? and I locally build CPU version with USE_CUDA=OFF, and it still pass

@trivialfis
Copy link
Member

Thank you for the quick fix! triggered the CI.

@trivialfis
Copy link
Member

Screenshot from 2022-11-22 14-59-21

@hcho3 Could you please help check whether the CI is working alright?

@hcho3
Copy link
Collaborator

hcho3 commented Nov 22, 2022

@trivialfis An EC2 worker running Windows got stuck and hung for 10 hours. I had to manually kill it.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 24, 2022

@trivialfis please help to trigger the CI. Thx

@trivialfis
Copy link
Member

Done.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 25, 2022

@trivialfis Seems the CI is not triggered.

@hcho3
Copy link
Collaborator

hcho3 commented Nov 25, 2022

I triggered it again.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Nov 25, 2022

Does the python test have some issues?

E           ImportError: /opt/python/envs/cpu_test/lib/python3.8/site-packages/_cffi_backend.cpython-38-x86_64-linux-gnu.so: symbol ffi_type_uint32 version LIBFFI_BASE_7.0 not defined in file libffi.so.7 with link time reference

}

@Override
public void setLabel(Column column) throws XGBoostError {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remind me what's the reason behind setters not being supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is renamed by DeviceQuantileDMatrix which is not supporting setter before (when the PR was merged). Will file another PR to support setter if it indeed has supported that.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Dec 2, 2022

@trivialfis @hcho3 please help to trigger the CI. Thx

@hcho3
Copy link
Collaborator

hcho3 commented Dec 2, 2022

Done

@wbo4958
Copy link
Contributor Author

wbo4958 commented Dec 2, 2022

@hcho3 @trivialfis please help to trigger the CI again, I just merged the latest commits into this PR. Thx

@wbo4958
Copy link
Contributor Author

wbo4958 commented Dec 3, 2022

@trivialfis please help to check why python test failed in this CI, I suppose this PR won't touch any python code.

@hcho3
Copy link
Collaborator

hcho3 commented Dec 3, 2022

@wbo4958 I re-created the machine env and re-triggered the tests. The CI is passing on the master branch, so hopefully it will remove the error.

@wbo4958
Copy link
Contributor Author

wbo4958 commented Dec 5, 2022

Thx @hcho3, @trivialfis please help to review again. Thx

@wbo4958 wbo4958 requested a review from trivialfis December 5, 2022 03:25
@trivialfis trivialfis merged commit f1e9bbc into dmlc:master Dec 5, 2022
@wbo4958 wbo4958 deleted the remove-warning branch April 23, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jvm-packages] Deprecate DeviceQuantileDMatrix.
3 participants