Use array interface for CSC matrix. #8672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
csc-array-adapter
branch
from
90f184b to
32436f9
Compare
|
May I ask what need to do for JVM packages? |
|
For Java/scala bindings, accept |
trivialfis
force-pushed
the
csc-array-adapter
branch
from
0d0dae6 to
abe84f2
Compare
trivialfis
changed the title
|
@wbo4958 Would you like to look into the jvm changes when you are available? |
|
sure, will do it. |
hcho3
reviewed
Jan 30, 2023
jvm-packages/xgboost4j/src/main/scala/ml/dmlc/xgboost4j/scala/DMatrix.scala
Show resolved
Hide resolved
trivialfis
force-pushed
the
csc-array-adapter
branch
from
fbb0fb2 to
e281443
Compare
|
For jvm code, LGTM. |
|
@hcho3 Could you please take another look into this PR? |
hcho3
approved these changes
Feb 3, 2023
Use array interface for CSC matrix and align the interface with CSR and dense. - Fix nthread issue in the R package DMatrix. - Unify the behavior of handling `missing` with other inputs. - Unify the behavior of handling `missing` around R, Python, Java, and Scala DMatrix. - Expose `num_non_missing` to the JVM interface. - Deprecate old CSR and CSC constructors.
trivialfis
force-pushed
the
csc-array-adapter
branch
from
1f0ae2c to
5b65b2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use array interface for CSC matrix and align the interface with CSR and dense.
missingwith other inputs.missingaround R, Python, Java, and Scala DMatrix.num_non_missingto the JVM interface.todos