Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] remove unused functions in xgboost.data #8695

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

jameslamb
Copy link
Contributor

Proposes removing two unused internal functions in the Python package:

  • xgboost.data._check_complex()
  • xgboost.data._to_data_type()

I'm unsure when the uses of these functions were removed, but I'm pretty confident that they're no longer used.

grep -R '_check_complex'

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for cleaning up the code! Let me double-check the _check_complex, it was required by sklearn estimator tests, I'm not sure why it's passing now.

@jameslamb
Copy link
Contributor Author

Ok yeah no problem!

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, the sklearn estimator check parametrize_with_checks no longer passes complex data for validation.

@trivialfis trivialfis merged commit 6933240 into dmlc:master Jan 19, 2023
@jameslamb jameslamb deleted the python/remove-unused branch January 19, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants