Fix cache with gc #8851
Merged
Fix cache with gc #8851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5bcac78.
trivialfis
commented
Feb 27, 2023
| @@ -52,4 +54,63 @@ TEST(DMatrixCache, Basic) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| TEST(DMatrixCache, MultiThread) { | |||
There was a problem hiding this comment.
I have run this test a few thousand times using the gtest_repeat, along with thread sanitizer.
RAMitchell
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8683 .
The previous cache uses static thread local memory implemented as part of the standard library. However, the Scala binding uses a different thread to call the
disposemethod, which calls into the booster destructor. As a result, the constructor and destructor are invoked by different threads, violating the cache cleanup process.A short-lived lock is required for enabling thread safety with the new DMatrix cache.