Optimize array interface input. #9090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type cast the array once instead of performing type casts for every individual element.
trivialfis
changed the title
RAMitchell
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type cast the array once instead of performing type casts for every individual element.
This is to prepare for multi-output with custom objectives. In that case, we will need to consume more diverse inputs for gradient (array with strides, c-order, f-order, etc). I plan to reuse the array interface for custom gradient, hence a small optimization.
Besides, I think this makes the code easier to follow as the operation is reduced to between
TensorViews, array interface bears no actual functionality and is only a representation of the input.