Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Automatically bump Rapids version in containers #9234

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jun 1, 2023

TODO:

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this affect Python tests? I have been using a conda environment file for development with RMM, maybe it's useful to upstream it here.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jun 1, 2023

Does this affect Python tests?

Yes.

I have been using a conda environment file for development with RMM

Currently, we don't use environment files because environment files don't support a parameter. Since we are adopting an automated solution to keep RAPIDS up to date, we can work around this restriction:

  • Move all Conda envs into environment files. Make sure to pin Rapids packages to specific versions: rapids=23.04, rmm=23.04 and so forth.
  • The automated script should periodically check for the latest RAPIDS release and update the Conda env files appropriately (by running sed to replace the version strings).

What do you think of this idea? If you are okay, I can update this pull request to organize all Conda envs as env files.

@trivialfis
Copy link
Member

Sounds good! I will submit a PR later for the environment file.

@trivialfis
Copy link
Member

Sounds good! I will submit a PR later for the environment file.

Let's skip this for now. I forgot that I couldn't enforce the CUDA version with mamba. Mamba just keep using the latest cuda toolkit components from the nvidia channel.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jun 2, 2023

@trivialfis Specifying cudatoolkit=11.8 doesn't work with Mamba?

@trivialfis
Copy link
Member

For some reason, no. It keeps downloading individual components like nsight-system and cudart as 12.1.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jun 2, 2023

Got it. Then let me merge this PR as it is.

@hcho3 hcho3 merged commit 288539a into dmlc:master Jun 2, 2023
@hcho3 hcho3 deleted the bump_rapids branch June 2, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants