Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #9332. xgboost4j-gpu_2.12-2.0.0: added libxgboost4j.so back. #9351

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fixes #9332. xgboost4j-gpu_2.12-2.0.0: added libxgboost4j.so back. #9351

merged 1 commit into from
Jul 3, 2023

Conversation

dotbg
Copy link
Contributor

@dotbg dotbg commented Jun 30, 2023 •
edited
Loading

Fixes #9332

@dotbg dotbg changed the title Fixes 9332. xgboost4j-gpu_2.12-2.0.0: added libxgboost4j.so back. Fixes #9332. xgboost4j-gpu_2.12-2.0.0: added libxgboost4j.so back. Jun 30, 2023
@trivialfis
Copy link
Member

cc @hcho3 @wbo4958

@dotbg
Copy link
Contributor Author

dotbg commented Jul 1, 2023 •
edited
Loading

Not sure whether I can do anything about the

Could not transfer artifact org.apache.maven.shared:maven-filtering:pom:3.3.1 from/to central (https://repo.maven.apache.org/maven2): transfer failed for https://repo.maven.apache.org/maven2/org/apache/maven/shared/maven-filtering/3.3.1/maven-filtering-3.3.1.pom: Connection reset ->

on windows build machine :(

@hcho3
Copy link
Collaborator

hcho3 commented Jul 1, 2023

It was an transient error. I restarted the test.

@dotbg
Copy link
Contributor Author

dotbg commented Jul 3, 2023

@trivialfis do I need to do anything else to get this merged ?

trivialfis
trivialfis approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the slow reply.

@dotbg
Copy link
Contributor Author

dotbg commented Jul 3, 2023

No worries. Could you, please, merge these changes?

@trivialfis
Copy link
Member

Yup, just waited a little bit for the CI on master branch to pass.

@trivialfis trivialfis merged commit bb2de1f into dmlc:master Jul 3, 2023
@dotbg
Copy link
Contributor Author

dotbg commented Jul 3, 2023

Thanks a lot!

@dotbg dotbg deleted the feature/issue-9332 branch July 3, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

@hcho3 hcho3 hcho3 approved these changes

@wbo4958 wbo4958 wbo4958 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not contains libxgboost4j.so in the xgboost4j-gpu_2.12-2.0.0-SNAPSHOT.jar
4 participants
@dotbg @trivialfis @hcho3 @wbo4958