Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device ordinal doc #9398

Merged
merged 17 commits into from
Jul 22, 2023
Merged

Device ordinal doc #9398

merged 17 commits into from
Jul 22, 2023

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Jul 19, 2023 •
edited
Loading

  • Rewrite GPU demos. notebook is converted to script to avoid committing additional png plots.
  • Add GPU demos into the sphinx gallery.
  • Add RMM demos into the sphinx gallery.
  • Test for firing threads with different device ordinals.

@trivialfis trivialfis mentioned this pull request Jul 19, 2023
Closed
@trivialfis
Copy link
Member Author

There are other mentions of gpu_hist scattered in doc strings. I will do a complete scan later.

@trivialfis trivialfis requested a review from RAMitchell July 21, 2023 01:32
hcho3
hcho3 requested changes Jul 21, 2023
View reviewed changes
demo/gpu_acceleration/tree_shap.py
model = xgb.train(param, dtrain, num_round)

# Compute shap values using GPU with xgboost
model.set_param({"device": "cuda"})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for demo

src/data/data.cc Outdated Show resolved Hide resolved
tests/python-gpu/test_from_cupy.py Outdated Show resolved Hide resolved
tests/python-gpu/test_gpu_with_sklearn.py Outdated Show resolved Hide resolved
doc/tutorials/monotonic.rst Outdated Show resolved Hide resolved
demo/rmm_plugin/README.rst Outdated Show resolved Hide resolved
demo/rmm_plugin/README.rst Outdated Show resolved Hide resolved
demo/rmm_plugin/README.rst Outdated Show resolved Hide resolved
@trivialfis trivialfis merged commit 275da17 into dmlc:master Jul 22, 2023
@trivialfis trivialfis deleted the device-ordinal-doc branch July 22, 2023 07:26
@ShellLM ShellLM mentioned this pull request Aug 11, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcho3 hcho3 hcho3 approved these changes

@RAMitchell RAMitchell Awaiting requested review from RAMitchell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @hcho3