Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Handle UTF-8 paths on Windows #9448

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[R] Handle UTF-8 paths on Windows #9448

merged 1 commit into from
Aug 9, 2023

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Aug 8, 2023 •
edited
Loading

  • Use the built-in method enc2utf8 to ensure that UTF-8 strings are passed to XGBoosterLoadModel and XGBoosterSaveModel.
  • Add a unit test for R

Follow-up for #9443

@hcho3 hcho3 merged commit 819098a into dmlc:master Aug 9, 2023
@hcho3 hcho3 deleted the handle_utf8_rpkg branch August 9, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivialfis trivialfis trivialfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcho3 @trivialfis