Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] remove default values in internal booster manipulation functions #9461

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

jameslamb
Copy link
Contributor

Similar to #9457.

Proposes removing default values in internal functions xgb.handleToBooster() and xgb.Booster.handle(), to force calling code to supply all arguments and therefore reduce the risk of "forgot to pass something and silently fell back to a default" types of bugs.

Thanks for your time and consideration.

Copy link
Member

@trivialfis trivialfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the refactoring!

@jameslamb
Copy link
Contributor Author

@trivialfis there are a few more small changes like this I'd like to propose... would you prefer that I group them into larger PRs? I was doing small PRs to make the reviews easier, but I see now that more activity in the repo can lead to some tests not running

https://buildkite.com/xgboost/xgboost-ci/builds/3177#0189e083-ef62-4968-a00d-7b89e7124063

RuntimeError: Testing rejected. Reason: Today's spending (36.74 USD) exceeded the budget (30.00 USD) allocated for today! The spending limit gets reset every midnight UTC.

I wouldn't want my tiny refactorings to box out testing on more impactful PRs.

@trivialfis
Copy link
Member

trivialfis commented Aug 10, 2023

Thank you for being considerate! Feel free to open PRs based on your own preference. We are heading toward a new release and don't have any major work going.

I think I can review larger cleanup PRs unless there's major optimization/overhaul, feel free to make your own schedule.

@jameslamb
Copy link
Contributor Author

Ok thanks very much, please do tell me if that ever changes. I want to be respectful of your time and the project's limited resources.

@trivialfis trivialfis merged commit 428f6cb into dmlc:master Aug 11, 2023
@jameslamb jameslamb deleted the r/default-values branch August 14, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants