Handle special characters in JSON model dump. #9474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
approved these changes
Aug 13, 2023
| char number[NumericLimits<float>::kToCharsSize]; | ||
| auto res = to_chars(number, number + sizeof(number), num->GetNumber()); | ||
| std::array<char, NumericLimits<float>::kToCharsSize> number; | ||
| auto res = to_chars(number.data(), number.data() + number.size(), num->GetNumber()); |
There was a problem hiding this comment.
Is it possible to use std::to_chars, now that we are using C++17? Not blocking this release, let's consider using std::to_chars in the future.
There was a problem hiding this comment.
The implementation is unspecified by the standard. MSVC can produce different result than GCC.
There was a problem hiding this comment.
Not for interger. I will do some cleanups after 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9352 .
Json.The test coverage for special characters is not quite complete at the moment. Expect some failures with features that need to parse the dump output. On top of my mind for things to test:
I tested model plot, which uses the
dotformat and it works fine with special characters.