Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 일정 조회 API 경로 수정 #283

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[FIX] 일정 조회 API 경로 수정 #283

merged 2 commits into from
Dec 3, 2024

Conversation

keemsebin
Copy link
Member

@keemsebin keemsebin commented Dec 3, 2024

관련 이슈

close #282

✨ 작업 내용

  • 일정 조회 API 경로 수정했습니다.
  • 모집 마감 기한 필터링 로직에서 시간까지 고려되어 시작 날짜가 오늘인 경우 dayjs('2024-12-03T23:59:59').isSameOrBefore(dayjs('2024-12-03')) 조건이 false로 평가되는 문제 상황이 있었습니다. (시간이 존재 하지 않을 경우 00:00:00이 적용됩니다.)
  • 날짜만 비교하도록 startOf('day') 사용했습니다!

🙏 기타 참고 사항

Copy link

github-actions bot commented Dec 3, 2024

👀 코드리뷰 전! Storybook 미리보기: https://66988c37c0f74bbb37d914e5-tljgkpkwoz.chromatic.com/

Copy link
Member

@jhsung23 jhsung23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다~~

@keemsebin keemsebin merged commit e8fd1a7 into main Dec 3, 2024
7 checks passed
@keemsebin keemsebin deleted the fix/#282-api branch December 3, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 일정 조회 API 경로 수정
2 participants