Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Moq from 4.18.4 to 4.20.69 #5802

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 1, 2023

Bumps Moq from 4.18.4 to 4.20.69.

Release notes

Sourced from Moq's releases.

v4.20.69

Let's make it more memorable when Moq became "safe" again.

What's Changed

v4.20.2

What's Changed

🐛 Fixed bugs

NOTE: in addition, there were potential privacy issues raised with regards to the SHA256 hashing of user' email to check for sponsorship, so it won't be coming back until that's properly addressed

Full Changelog: moq/moq.spikes@v4.20.1...v4.20.2

v4.20.1

What's Changed

✨ Implemented enhancements

  • Add Sponsor button to package readme 💜

Full Changelog: moq/moq.spikes@v4.20.0...v4.20.1

v4.20.0

What's Changed

✨ Implemented enhancements

🔨 Other

New Contributors

... (truncated)

Changelog

Sourced from Moq's changelog.

4.20.69 (2023-08-11)

4.20.2 (2023-08-09)

🐛 Fixed bugs

NOTE: in addition, there were potential privacy issues raised with regards to the SHA256 hashing of user' email to check for sponsorship, so it won't be coming back until that's properly addressed

4.20.1 (2023-08-08)

✨ Implemented enhancements

  • Add Sponsor button to package readme 💜

4.20.0 (2023-08-07)

✨ Implemented enhancements

  • Mock<T>.RaiseAsync method for raising "async" events, i.e. events that use a Func<..., Task> or Func<..., ValueTask> delegate. (@​stakx, #1313)
  • setup.Verifiable(Times times, [string failMessage]) method to specify the expected number of calls upfront. mock.Verify[All] can then be used to check whether the setup was called that many times. The upper bound (maximum allowed number of calls) will be checked right away, i.e. whenever a setup gets called. (@​stakx, #1319)

🔨 Other

Fixed

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [Moq](https://github.com/moq/moq) from 4.18.4 to 4.20.69.
- [Release notes](https://github.com/moq/moq/releases)
- [Changelog](https://github.com/moq/moq/blob/main/CHANGELOG.md)
- [Commits](moq/moq.spikes@v4.18.4...v4.20.69)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .net code Type: Maintenance labels Sep 1, 2023
@GerardSmit
Copy link
Contributor

Note, I would take care with updating Moq. In version 4.20 the developer added SponsorLink. I've also posted this in dotnet/runtime, so if you want to read more: dotnet/runtime#90222.

As of the latest version, 4.20.69, SponsorLink was removed because the developer received a lot of negative feedback, but it's assumed that SponsorLink will return in a "more privacy manner". It's quite vague but more details are here: devlooped/moq#1396

A maintainer of the project created a fork (https://github.com/stakx/moq) that won't include SponsorLink.

@mitchelsellers
Copy link
Contributor

@GerardSmit I agree we need to monitor this situation and upgrade carefully, however, I have confidence at this time at least that upgrading to 4.20.69 is acceptable for now. I don't believe it is fully worth jumping ship yet just my $0.02

@valadas
Copy link
Contributor

valadas commented Oct 10, 2023

I agree, the situation appears to be under control for now. I did migrate some of my projects to NSubstitute so if push comes to shove, I can help transition but it would be kinda massive work on this project :)

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 1, 2024

Superseded by #5948.

@dependabot dependabot bot closed this Feb 1, 2024
@dependabot dependabot bot deleted the dependabot/nuget/Moq-4.20.69 branch February 1, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Pull requests that update .net code Type: Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants