Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement registrar methods for Domain Prices API #103
Implement registrar methods for Domain Prices API #103
Changes from 5 commits
692c597
e89f35f
3558dc1
5fd5361
529e4e3
3502f35
c588719
29d58df
1b3a4b7
f3c8264
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing the docs here. It breaks the lint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weppos thanks!
shouldn't we add this on CI? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be great. Sadly, it's a bit complicated:
Makefile
in the past b7733b8, sadly once you add aMakefile
Travis will rely entirely on it and you will need a non trivial amount of customization to make the build pass in both module and non-module versions. Things would be easier if we would only use module-aware versions (1.11 or above).golint
is not enough to break the build. It's a highly recommended standard. We could add it asgolint ./...
in the travis.yml file, but it would cause the build to break if anything is invalid (and right now we have one lint warning). The current warning is actually a false positive due to a naming conflict between the webook package and the Webhook as result of the Webhook API. I am not sure how to ignore this as golint doesn't have a way to address false positives. We should probably upgrade togolangci-lint
which instead does.