Implement checkZoneDistribution #64
Conversation
jodosha
added
feature
ready-for-review
There was a problem hiding this comment.
On hold until dnsimple/dnsimple-developer#153 is approved and merged.
weppos
removed
the
ready-for-review
jodosha
dismissed
weppos’s stale review
Documentation is live. I updated code with consistent naming, and updated the fixtures.
jodosha
added
the
ready-for-review
jodosha
dismissed
weppos’s stale review
I implemented both the features, as requested
| import "fmt" | ||
|
|
||
| // ZoneDistribution is the result of the zone distribution check. | ||
| type ZoneDistribution struct { |
There was a problem hiding this comment.
How do you feel about renaming this struct into DistributionResult, and having both zoneDistributionResponse and zoneRecordDistributionResponse to use the same struct?
We don't pay for structs, but I hardly see the reason ATM to use 2 different types. It may makes things harder on the consumer side (especially given they are not an interface, and Go is strictly typed).
There was a problem hiding this comment.
I intentionally didn't declared an unified type because it looked like premature DRY.
On the other hand, we unify a lot of responses of the same type. Eg. registrar and domain services use domainResponse . So I think we can unify this as well.
No description provided.