tech/improve icons to avoid fetch queries #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
laruiss
commented
Jan 6, 2025
laruiss
commented
- feat: 🔧 externalise @iconify/vue
- feat: ⚡ déplace les meta dans leur propre export
- Ceci rend possible l’addition de collections personnalisées (cette addition doit être faite avec `addCollection` de `@iconify/vue`)
- le preset pour autoimport et le resolver de composants
n’ont rien à faire dans le bundle final, ils sont désormais à part
- les imports dans vite.config.ts des apps doivent être modifiés:
```diff
import {
vueDsfrAutoimportPreset,
vueDsfrComponentResolver,
-} from '@laruiss/vue-dsfr'
+} from '@laruiss/vue-dsfr/meta'
```
BREAKING CHANGE: il faut changer les imports dans le `vite.config.ts`
✅ Deploy Preview for vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for demo-vue-dsfr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.