Skip to content

Commit

Permalink
perf: upgrade to Angular 19 (#32)
Browse files Browse the repository at this point in the history
* perf: upgrade to Angular 19

* fix: inject Sentry trace service initialization

* perf: update dependencies
  • Loading branch information
ittipatken authored Jan 19, 2025
1 parent 1101288 commit 008cc04
Show file tree
Hide file tree
Showing 8 changed files with 2,010 additions and 2,599 deletions.
42 changes: 21 additions & 21 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
},
"private": true,
"dependencies": {
"@angular/common": "^18.2.13",
"@angular/core": "^18.2.13",
"@angular/fire": "^18.0.1",
"@angular/forms": "^18.2.13",
"@angular/platform-browser": "^18.2.13",
"@angular/platform-browser-dynamic": "^18.2.13",
"@angular/router": "^18.2.13",
"@angular/service-worker": "^18.2.13",
"@angular/common": "^19.1.1",
"@angular/core": "^19.1.1",
"@angular/fire": "^19.0.0",
"@angular/forms": "^19.1.1",
"@angular/platform-browser": "^19.1.1",
"@angular/platform-browser-dynamic": "^19.1.1",
"@angular/router": "^19.1.1",
"@angular/service-worker": "^19.1.1",
"@ionic/angular": "^8.4.1",
"@sentry/angular": "^8.50.0",
"@sentry/cli": "^2.40.0",
Expand All @@ -35,20 +35,20 @@
"video.js": "^8.21.0",
"videojs-hotkeys": "^0.2.30",
"videojs-youtube": "^3.0.1",
"zone.js": "^0.14.10"
"zone.js": "^0.15.0"
},
"devDependencies": {
"@angular-devkit/architect": "^0.1802.12",
"@angular-devkit/build-angular": "^18.2.12",
"@angular-eslint/builder": "^18.4.3",
"@angular-eslint/eslint-plugin": "^18.4.3",
"@angular-eslint/eslint-plugin-template": "^18.4.3",
"@angular-eslint/schematics": "^18.4.3",
"@angular-eslint/template-parser": "^18.4.3",
"@angular/cli": "^18.2.12",
"@angular/compiler": "^18.2.13",
"@angular/compiler-cli": "^18.2.13",
"@angular/language-service": "^18.2.13",
"@angular-devkit/architect": "^0.1901.1",
"@angular-devkit/build-angular": "^19.1.1",
"@angular-eslint/builder": "^19.0.2",
"@angular-eslint/eslint-plugin": "^19.0.2",
"@angular-eslint/eslint-plugin-template": "^19.0.2",
"@angular-eslint/schematics": "^19.0.2",
"@angular-eslint/template-parser": "^19.0.2",
"@angular/cli": "^19.1.1",
"@angular/compiler": "^19.1.1",
"@angular/compiler-cli": "^19.1.1",
"@angular/language-service": "^19.1.1",
"@ionic/angular-toolkit": "^11.0.1",
"@types/jasmine": "~5.1.5",
"@types/jasminewd2": "^2.0.13",
Expand All @@ -73,4 +73,4 @@
"typescript": "~5.5.4"
},
"description": "An Ionic project"
}
}
4,546 changes: 1,982 additions & 2,564 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import { Platform } from '@ionic/angular/standalone';
@Component({
selector: 'app-root',
templateUrl: 'app.component.html',
styleUrls: ['app.component.scss']
styleUrls: ['app.component.scss'],
standalone: false
})
export class AppComponent {
constructor(
Expand Down
12 changes: 4 additions & 8 deletions src/app/app.module.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {APP_INITIALIZER, ErrorHandler, NgModule} from '@angular/core';
import { ErrorHandler, NgModule, inject, provideAppInitializer } from '@angular/core';
import { BrowserModule } from '@angular/platform-browser';
import {Router, RouteReuseStrategy} from '@angular/router';
import * as Sentry from "@sentry/angular";
Expand Down Expand Up @@ -56,13 +56,9 @@ import { getFirestore, provideFirestore } from '@angular/fire/firestore';
provide: Sentry.TraceService,
deps: [Router],
},
{
provide: APP_INITIALIZER,
useFactory: () => () => {
},
deps: [Sentry.TraceService],
multi: true,
},
provideAppInitializer(() => {
inject(Sentry.TraceService);
}),
],
})
export class AppModule {
Expand Down
3 changes: 1 addition & 2 deletions src/app/home/course/course.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { NgClass, AsyncPipe, DecimalPipe, DatePipe } from '@angular/common';
selector: 'app-course',
templateUrl: './course.page.html',
styleUrls: ['./course.page.scss'],
standalone: true,
imports: [
IonHeader,
IonToolbar,
Expand Down Expand Up @@ -48,7 +47,7 @@ import { NgClass, AsyncPipe, DecimalPipe, DatePipe } from '@angular/common';
AsyncPipe,
DecimalPipe,
DatePipe,
],
]
})
export class CoursePage implements OnInit, AfterViewInit, OnDestroy {
@ViewChild('videoPlayer') videoPlayerElement: ElementRef;
Expand Down
1 change: 0 additions & 1 deletion src/app/home/home.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { NgStyle, AsyncPipe } from '@angular/common';
selector: 'app-home',
templateUrl: 'home.page.html',
styleUrls: ['home.page.scss'],
standalone: true,
imports: [IonHeader, IonToolbar, IonTitle, IonButtons, IonButton, IonIcon, IonContent, IonGrid, IonRow, IonCol, IonCard, RouterLink, NgStyle, IonCardHeader, IonCardTitle, AsyncPipe]
})
export class HomePage implements OnInit {
Expand Down
1 change: 0 additions & 1 deletion src/app/home/list/list.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { NgStyle, AsyncPipe } from '@angular/common';
selector: 'app-list',
templateUrl: './list.page.html',
styleUrls: ['./list.page.scss'],
standalone: true,
imports: [IonHeader, IonToolbar, IonButtons, RouterLink, IonBackButton, IonTitle, NgStyle, IonContent, IonList, IonItem, IonLabel, AsyncPipe]
})
export class ListPage implements OnInit {
Expand Down
1 change: 0 additions & 1 deletion src/app/welcome/welcome.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { AuthService } from '../auth.service';
selector: 'app-welcome',
templateUrl: './welcome.page.html',
styleUrls: ['./welcome.page.scss'],
standalone: true,
imports: [IonContent, IonCard, IonCardHeader, IonCardTitle, IonCardContent, IonButton, IonText]
})
export class WelcomePage implements OnInit, OnDestroy {
Expand Down

0 comments on commit 008cc04

Please sign in to comment.