Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine-based Julia 1.5 image #47

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Add Alpine-based Julia 1.5 image #47

merged 3 commits into from
Jun 30, 2020

Conversation

lungben
Copy link

@lungben lungben commented Jun 28, 2020

The new musl Linux binaries for Julia 1.5 allow a rather simple creation of an Alpine Linux based Julia image.
The size of this image is 380 MB, compared to 456 MB for the Debian based one.

I manually created the Dockerfile for now, integration into the automatic Dockerfile update script is still open.

@tianon
Copy link
Member

tianon commented Jun 30, 2020

Neat! Thanks for taking a first pass! 🙏

I've pushed fb8e276 which adds the appropriate template and updates the associated scripts, so this should now be running the image tests via GitHub Actions. 👍 🥳

Diff:
$ diff -u <(bashbrew cat julia) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63	2020-06-30 12:10:06.179184241 -0700
+++ /dev/fd/62	2020-06-30 12:10:06.179184241 -0700
@@ -7,6 +7,10 @@
 GitCommit: 6a716f3d1f28aaafce298c33e27a053443eec6fb
 Directory: 1.5-rc/buster
 
+Tags: 1.5.0-rc1-alpine3.12, 1.5.0-alpine3.12, 1.5-alpine3.12, 1.5-rc-alpine3.12, rc-alpine3.12, 1.5.0-rc1-alpine, 1.5.0-alpine, 1.5-alpine, 1.5-rc-alpine, rc-alpine
+GitCommit: fb8e27612702b2dc93f109947a4df0f99477f3b0
+Directory: 1.5-rc/alpine3.12
+
 Tags: 1.5.0-rc1-windowsservercore-ltsc2016, 1.5.0-windowsservercore-ltsc2016, 1.5-windowsservercore-ltsc2016, 1.5-rc-windowsservercore-ltsc2016, rc-windowsservercore-ltsc2016
 SharedTags: 1.5.0-rc1, 1.5.0, 1.5, 1.5-rc, rc
 Architectures: windows-amd64

There are no upstream Alpine + i386 builds.
@tianon tianon merged commit 92c1731 into docker-library:master Jun 30, 2020
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 30, 2020
Changes:

- docker-library/julia@92c1731: Merge pull request docker-library/julia#47 from lungben/master
- docker-library/julia@4c89f47: Exclude Alpine variants in GitHub Actions i386 test builds
- docker-library/julia@fb8e276: Add Alpine template and resync with how Debian images are structured
- docker-library/julia@9297767: Dockerfile for Alpine-based Julia 1.5 added
@lungben
Copy link
Author

lungben commented Jul 1, 2020

Thank you for the integration!

@fredrikekre
Copy link

fredrikekre commented Jul 1, 2020

I will just note here that Julia with musl libc has known problems and is therefore listed as Tier 3: https://julialang.org/downloads/#currently_supported_platforms. I don't know if that is something that is worth adding to the image description on Docker Hub (I don't know what the policies are).

For reference: JuliaLang/julia#28805, JuliaLang/julia#36458

@tianon
Copy link
Member

tianon commented Jul 1, 2020

We have some standard boilerplate docs that get added to any image with an alpine variant automatically (https://github.com/docker-library/docs/blob/33f50113e340d5fe24fb678eea38f8e0ad8595ca/.template-helpers/variant-alpine.md), but I definitely agree that something more specific referencing the support tiering is warranted (especially since ARMv7 is Tier 3 also)!

@tianon
Copy link
Member

tianon commented Jul 1, 2020

Opened a first pass at docker-library/docs#1757 that I'd love to get some eyes on. 😄 ❤️ 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants