Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF8 Encoded SQL #1336

Closed
ghost opened this issue Jan 13, 2016 · 3 comments
Closed

UTF8 Encoded SQL #1336

ghost opened this issue Jan 13, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 13, 2016

I recently completed a project that required the initial database to contain UTF8 encoded text. Since the initdb scripts are assumed to be ascii encoded, I had to make a minor modification to docker-entrypoint.sh.

mysql=( mysql --protocol=socket --default_character_set=utf8 -uroot )

This change was not a big deal for me, but I am raising the question as to whether this would be a good default. I can't think of any way it breaks compatibility with existing scripts, and the new default would provide a real benefit to anyone working with UTF8 encoded data.

Of course, an even better solution may be to use a variable.
(One step at a time...)

@tianon
Copy link
Member

tianon commented Jan 13, 2016 via email

@ghost
Copy link
Author

ghost commented Jan 13, 2016

That pull request is regarding the default character-set of the initial database. This issue, however, is about the encoding of sql scripts run from initdb. The scripts can easily change the encoding of the database, but the encoding of the script file itself is the problem I would like to address.

I will try creating another issue on the other page.

@ghost ghost closed this as completed Jan 13, 2016
@ghost
Copy link
Author

ghost commented Jan 13, 2016

docker-library/mysql#131

Starefossen pushed a commit to Starefossen/official-images that referenced this issue Jan 13, 2016
PR-URL: docker-library#1336

Related: nodejs/node#4626
Related: nodejs/docker-node#86

Signed-off-by: Hans Kristian Flaatten <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant