Do not try to create databases that already exist #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were already checking for whether `POSTGRES_DB` was set to `postgres`, but this was the underlying motivation for that check (and it turns out that this applies for values of at least `template0` and `template1` as well).
yosifkit
approved these changes
Dec 28, 2020
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 29, 2020
Changes: - docker-library/postgres@03e7695: Merge pull request docker-library/postgres#801 from infosiftr/db-exists - docker-library/postgres@eaeb73d: Merge pull request docker-library/postgres#804 from infosiftr/chmod-no-fail - docker-library/postgres@36ffea2: Adjust "chmod" to not fail (since PostgreSQL validates this itself later) - docker-library/postgres@11e397d: Do not try to create databases that already exist - docker-library/postgres@3690694: Merge pull request docker-library/postgres#797 from infosiftr/rc-beta-alpha - docker-library/postgres@dba8ec0: Adjust tagging to enforce explicit pre-release opt-in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already checking for whether
POSTGRES_DBwas set topostgres, but this was the underlying motivation for that check (and it turns out that this applies for values of at leasttemplate0andtemplate1as well).Closes #794
(Just to keep the thread, https://stackoverflow.com/a/18389184/433558 still makes me depressed 😅 - #794 (comment))