-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpine 3.14 #348
Add Alpine 3.14 #348
Conversation
It seems they've done some backporting of that patch already (to 2.7): ruby/ruby@29bbad9 Are they are going to continue? Do we need to hold off Alpine 3.14 until they've finished? |
d954d05
to
4ea3e6e
Compare
I'm not sure. The website states that they are soon EOL. This will simplify the setup a lot. |
The autoconf issue is fixed with the patch. The workaround can be removed once 2.7.4 is released but it's still required for 2.6 unless they backport it to that branch. 2.5 is EOL and will likely disappear in the next release cycle. |
This comment has been minimized.
This comment has been minimized.
Sorry for the delay. We are currently working on issues with building Alpine 3.14 based images and so I'd rather not merge this yet. |
@yosifkit I can understand caution considering the CI checks on this pipeline looks good as well. |
It was an issue with the actual official images build infrastructure, not GitHub Actions. However, builders are updated now so this should be safe to review/merge. |
I'm not a huge fan of the obscure patches, especially the even more obscure hash munging we have to do to switch between them. 😞 |
@tianon Is there a different approach that you would suggest instead? |
My primary concern ATM is the ability to read the code later and still be able to trace/follow where these values come from (and how/where to update them); having the commit and checksums split between several files (and having The patch in https://git.alpinelinux.org/aports/tree/main/ruby/remove-broken-autoconf-section.patch?h=3.14-stable is also interesting (just removing the broken section wholesale). However, going through https://bugs.ruby-lang.org/issues/14387 again (which we're still applying a patch for, years later 😩) makes me wonder if Ruby even really wants to support Alpine. 😕 |
The patch for 2.7 ships with the next release but there is no ETA. In the worst case we need to keep the patch for 2.6 or skip Alpine 3.14 for it. |
Applied this commit/change with a slightly different approach (redoing the whole template engine first 😂) over in #349 👍 |
No description provided.