Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpine 3.14 #348

Closed
wants to merge 1 commit into from
Closed

Add Alpine 3.14 #348

wants to merge 1 commit into from

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Jun 16, 2021

No description provided.

@yosifkit
Copy link
Member

It seems they've done some backporting of that patch already (to 2.7): ruby/ruby@29bbad9

Are they are going to continue? Do we need to hold off Alpine 3.14 until they've finished?

@J0WI J0WI force-pushed the alpine-3.14 branch 2 times, most recently from d954d05 to 4ea3e6e Compare June 16, 2021 21:04
@J0WI
Copy link
Contributor Author

J0WI commented Jun 16, 2021

Are they are going to continue?

I'm not sure. The website states that they are soon EOL. This will simplify the setup a lot.

@lbg-raghu-vennam
Copy link

lbg-raghu-vennam commented Jun 18, 2021

@J0WI / @yosifkit is this PR merge on hold due to issue with autoconf and that issue to be sorted ?

We have a dependency on this base image and are interested if there is an ETA for this merge.

@J0WI
Copy link
Contributor Author

J0WI commented Jun 18, 2021

The autoconf issue is fixed with the patch. The workaround can be removed once 2.7.4 is released but it's still required for 2.6 unless they backport it to that branch. 2.5 is EOL and will likely disappear in the next release cycle.

@lbg-raghu-vennam

This comment has been minimized.

@yosifkit
Copy link
Member

Sorry for the delay. We are currently working on issues with building Alpine 3.14 based images and so I'd rather not merge this yet.

@lbg-raghu-vennam
Copy link

@yosifkit I can understand caution considering the golang images are failing, is there any ETA as to when we can expect this.

CI checks on this pipeline looks good as well.

@tianon
Copy link
Member

tianon commented Jun 25, 2021

It was an issue with the actual official images build infrastructure, not GitHub Actions.

However, builders are updated now so this should be safe to review/merge.

@tianon
Copy link
Member

tianon commented Jun 30, 2021

I'm not a huge fan of the obscure patches, especially the even more obscure hash munging we have to do to switch between them. 😞

@woodhull
Copy link

woodhull commented Jul 1, 2021

@tianon Is there a different approach that you would suggest instead?

@tianon
Copy link
Member

tianon commented Jul 1, 2021

My primary concern ATM is the ability to read the code later and still be able to trace/follow where these values come from (and how/where to update them); having the commit and checksums split between several files (and having sed replace one checksum with another) is going to make this a bit challenging to maintain. Ideally we'd do a conversion like docker-library/postgres#852 here (which would allow us to maintain these directly in Dockerfile-alpine.template, which would help), but that's a much larger lift. 😞

The patch in https://git.alpinelinux.org/aports/tree/main/ruby/remove-broken-autoconf-section.patch?h=3.14-stable is also interesting (just removing the broken section wholesale).

However, going through https://bugs.ruby-lang.org/issues/14387 again (which we're still applying a patch for, years later 😩) makes me wonder if Ruby even really wants to support Alpine. 😕

@J0WI
Copy link
Contributor Author

J0WI commented Jul 2, 2021

The patch for 2.7 ships with the next release but there is no ETA. In the worst case we need to keep the patch for 2.6 or skip Alpine 3.14 for it.

@tianon
Copy link
Member

tianon commented Jul 2, 2021

Applied this commit/change with a slightly different approach (redoing the whole template engine first 😂) over in #349 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants