Fix load balancer traffic policy #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes two changes: First, it upgrades the syntax to use newer version of the external traffic policy. This is based on testing on my Kubernetes 1.15 cluster, and was discovered from [this reference](kubernetes/ingress-nginx#1924) Second, it makes the non-load-balancer case switch to Cluster policy, which is necessary to allow the cluster to route NodePort traffic without a Kubernetes load balancer Also, fixed tiny whitespace nit
|
Great fix, thanks @bklang ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes:
First, it upgrades the syntax to use newer version of the external traffic policy. This is based on testing on my Kubernetes 1.15 cluster, and was discovered from this reference
Second, it makes the non-load-balancer case switch to Cluster policy, which is necessary to allow the cluster to route NodePort traffic without a Kubernetes load balancer
Also, fixed tiny whitespace nit