ci: split docker install integration tests #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
ci-split-docker-install-tests
branch
8 times, most recently
from
80c9dfb to
b367b8a
Compare
crazy-max
force-pushed
the
ci-split-docker-install-tests
branch
from
b367b8a to
3a3d393
Compare
vvoland
reviewed
Nov 25, 2024
__tests__/docker/install.test.itg.ts
Outdated
Comment on lines
29
to
37
| // prettier-ignore | ||
| test.each([ | ||
| {type: 'image', tag: '27.3.1'} as InstallSourceImage, | ||
| {type: 'image', tag: 'master'} as InstallSourceImage, | ||
| {type: 'image', tag: 'latest'} as InstallSourceImage, | ||
| {type: 'archive', version: 'v26.1.4', channel: 'stable'} as InstallSourceArchive, | ||
| {type: 'archive', version: 'latest', channel: 'stable'} as InstallSourceArchive, | ||
| ])( | ||
| 'install docker %s', async (source) => { |
There was a problem hiding this comment.
It would still be nice to run these tests outside of CI for development purposes.
WDYT about keeping them, but only use them if the DOCKER_INSTALL_* envs are unset?
There was a problem hiding this comment.
Yes I think that's fine, let me change this
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
ci-split-docker-install-tests
branch
from
3a3d393 to
9e42346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.